Reaction Bugfixes


#1

Hi everyone

I’m wrapping up my marketplace extensions for Reaction and made an overview of all the bugfixes I did in Reaction packages since I forked mid 0.12.
I want to make my fork mergeable again with Reaction HEAD.

I would like to invite you to comment on these points and let me know which bugs are already fixed in the meantime and which things you don’t see as bugs at all and I shouldn’t bother making a PR for.

Thanks!


#2

Using the row numbers below

  • 7 not sure
  • 18 not fixed
  • 13 not fixed
  • 16 not fixed
  • 19 not fixed
  • 24 not sure
  • 29 not fixed
  • 32 not fixed
  • 37 not fixed
  • 40 should be fixed
  • 43 not fixed, but should be configurable by shop owner
  • 48 not sure
  • 49 not sure, doesn’t seem so
  • 52 not fixed
  • 53 not fixed
  • 56 not fixed
  • 61 not fixed
  • 62 not fixed
  • 62 not fixed
  • 68 fixed
  • 69 fixed
  • 72 maybe fixed. moved the autorun up into products.js, subscription still exists within it (whats the issue?)
  • 75 might be fixed, along with some added currency localization
  • 78 not sure, never seen the issue
  • 79 not sure, never seen the issue
  • 82 not fixed, template not currently used by us
  • 83 not fixed, template not currently used by us
  • 86 not sure, never seen the issue, and template not used
  • 87 not sure, never seen the issue, and template not used
  • 92 some issues in collections 2 have been fixed, but is deprecated so we maybe need to find a different solution to it
  • 97 should be fixed

#3

Thanks Mike!

I forgot to mention I made the table editable by everyone, so you could have made your comments directly :slight_smile:
No worries, I’ve added them.

I’ll check the uncertain ones and submit PRs.